software-engineering/spark-vllm-docker
2
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed bug with CONTAINER_NAME variable

Browse Source
This commit is contained in:
Eugene Rakhmatulin
2026-03-25 14:42:01 -07:00
parent ad2cd3373f
commit 07fac71dac
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.env.example
View File

@@ -15,10 +15,11 @@ IB_IF="ib0"
MASTER_PORT="29501" MASTER_PORT="29501"
# CONTAINER_NAME: Container name (default: vllm_node) # CONTAINER_NAME: Container name (default: vllm_node)
# Note: This is a configuration variable, NOT passed as env var to container
CONTAINER_NAME="vllm_node" CONTAINER_NAME="vllm_node"
# Container environment variables # Container environment variables
# Any variable starting with CONTAINER_ will be converted to -e flags # Any variable starting with CONTAINER_ (except CONTAINER_NAME) will be converted to -e flags
# Example: CONTAINER_NCCL_DEBUG=INFO becomes -e NCCL_DEBUG=INFO # Example: CONTAINER_NCCL_DEBUG=INFO becomes -e NCCL_DEBUG=INFO
CONTAINER_NCCL_DEBUG="INFO" CONTAINER_NCCL_DEBUG="INFO"
CONTAINER_HF_TOKEN="your_huggingface_token_here" CONTAINER_HF_TOKEN="your_huggingface_token_here"

9
launch-cluster.sh
View File

@@ -78,14 +78,15 @@ usage() {
echo " IB_IF InfiniBand interface name" echo " IB_IF InfiniBand interface name"
echo " MASTER_PORT Port for cluster coordination (default: 29501)" echo " MASTER_PORT Port for cluster coordination (default: 29501)"
echo " CONTAINER_NAME Container name (default: vllm_node)" echo " CONTAINER_NAME Container name (default: vllm_node)"
echo " CONTAINER_* Any variable starting with CONTAINER_ becomes -e flag" echo " CONTAINER_* Any variable starting with CONTAINER_ (except CONTAINER_NAME)"
echo " Example: CONTAINER_NCCL_DEBUG=INFO -> -e NCCL_DEBUG=INFO" echo " becomes -e flag. Example: CONTAINER_NCCL_DEBUG=INFO -> -e NCCL_DEBUG=INFO"
echo "" echo ""
echo "Example .env file:" echo "Example .env file:"
echo " CLUSTER_NODES=192.168.1.1,192.168.1.2" echo " CLUSTER_NODES=192.168.1.1,192.168.1.2"
echo " ETH_IF=eth0" echo " ETH_IF=eth0"
echo " IB_IF=ib0" echo " IB_IF=ib0"
echo " MASTER_PORT=29501" echo " MASTER_PORT=29501"
echo " CONTAINER_NAME=vllm_node"
echo " CONTAINER_NCCL_DEBUG=INFO" echo " CONTAINER_NCCL_DEBUG=INFO"
echo " CONTAINER_HF_TOKEN=abc123" echo " CONTAINER_HF_TOKEN=abc123"
echo "" echo ""
@@ -286,7 +287,11 @@ if [[ -n "$NCCL_DEBUG_VAL" ]]; then
fi fi
# Add container environment variables from .env (CONTAINER_* pattern) # Add container environment variables from .env (CONTAINER_* pattern)
# Excludes CONTAINER_NAME which is a configuration variable, not an env var
for env_var in $(compgen -v DOTENV_CONTAINER_); do for env_var in $(compgen -v DOTENV_CONTAINER_); do
# Skip CONTAINER_NAME as it's a configuration variable
[[ "$env_var" == "DOTENV_CONTAINER_NAME" ]] && continue
# Get the value # Get the value
value="${!env_var}" value="${!env_var}"