diff --git a/.env.example b/.env.example index 2a3acbb..6f3f05e 100644 --- a/.env.example +++ b/.env.example @@ -15,10 +15,11 @@ IB_IF="ib0" MASTER_PORT="29501" # CONTAINER_NAME: Container name (default: vllm_node) +# Note: This is a configuration variable, NOT passed as env var to container CONTAINER_NAME="vllm_node" # Container environment variables -# Any variable starting with CONTAINER_ will be converted to -e flags +# Any variable starting with CONTAINER_ (except CONTAINER_NAME) will be converted to -e flags # Example: CONTAINER_NCCL_DEBUG=INFO becomes -e NCCL_DEBUG=INFO CONTAINER_NCCL_DEBUG="INFO" CONTAINER_HF_TOKEN="your_huggingface_token_here" diff --git a/launch-cluster.sh b/launch-cluster.sh index 1f6bfb9..40500b5 100755 --- a/launch-cluster.sh +++ b/launch-cluster.sh @@ -78,14 +78,15 @@ usage() { echo " IB_IF InfiniBand interface name" echo " MASTER_PORT Port for cluster coordination (default: 29501)" echo " CONTAINER_NAME Container name (default: vllm_node)" - echo " CONTAINER_* Any variable starting with CONTAINER_ becomes -e flag" - echo " Example: CONTAINER_NCCL_DEBUG=INFO -> -e NCCL_DEBUG=INFO" + echo " CONTAINER_* Any variable starting with CONTAINER_ (except CONTAINER_NAME)" + echo " becomes -e flag. Example: CONTAINER_NCCL_DEBUG=INFO -> -e NCCL_DEBUG=INFO" echo "" echo "Example .env file:" echo " CLUSTER_NODES=192.168.1.1,192.168.1.2" echo " ETH_IF=eth0" echo " IB_IF=ib0" echo " MASTER_PORT=29501" + echo " CONTAINER_NAME=vllm_node" echo " CONTAINER_NCCL_DEBUG=INFO" echo " CONTAINER_HF_TOKEN=abc123" echo "" @@ -286,7 +287,11 @@ if [[ -n "$NCCL_DEBUG_VAL" ]]; then fi # Add container environment variables from .env (CONTAINER_* pattern) +# Excludes CONTAINER_NAME which is a configuration variable, not an env var for env_var in $(compgen -v DOTENV_CONTAINER_); do + # Skip CONTAINER_NAME as it's a configuration variable + [[ "$env_var" == "DOTENV_CONTAINER_NAME" ]] && continue + # Get the value value="${!env_var}"